Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the use_sim_time parameter for rclpy nodes #240

Closed
2 tasks
dhood opened this issue Sep 20, 2018 · 4 comments
Closed
2 tasks

Respect the use_sim_time parameter for rclpy nodes #240

dhood opened this issue Sep 20, 2018 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@dhood
Copy link
Member

dhood commented Sep 20, 2018

There is support for Clocks that use ROS Time as described in this design document. It was added in this PR.

Clocks can be set to have ROS time "active" (will use the value seen on the /clock topic as its time) by calling time_source.ros_time_is_active = True.

A node has a time source associated with it (added in #210). At the time of that PR, parameters were not available in rclpy, so the node's time source does not respond to the use_sim_time parameter:

# TODO(dhood): use sim time if parameter has been set on the node.

As of #214, parameters are available in rclpy.

Tasks to get rclpy nodes to respond to the use_sim_time parameter:

  • Add a parameter callback that detects if use_sim_time has been set on the node.
  • Add tests that the node's clock output matches what's expected based on the combination of use_sim_time parameter and the presence of a /clock publisher. These are the tests in rclcpp.
@dhood dhood added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 20, 2018
@dhood dhood added this to the crystal milestone Sep 20, 2018
@shivangg
Copy link

@dhood I'd like to work on this issue. Can you assign it to me?

@sloretz
Copy link
Contributor

sloretz commented Sep 25, 2018

@shivangg Thanks!

I can't assign the issue to you (isaacs/github#100), but your contribution is still very welcome. When you make a pull request add the text connects to ros2/rclpy#240 to the PR description. That will link the PR and issue on the waffle board.

@mkhansenbot
Copy link

@shivangg - I'm in need of this functionality now for testing ROS2 Navigation, did you get this to work?

@jacobperron
Copy link
Member

Resolved by #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants