Add param callback to time_source #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
requested changes
Mar 30, 2019
Signed-off-by: vinnamkim <vinnam.kim@gmail.com>
Signed-off-by: vinnamkim <vinnam.kim@gmail.com>
jacobperron
approved these changes
Apr 1, 2019
|
Test failures are unrelated. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets to #240
Since it seems there have been no response on #240 for a long time, I made this PR. However, It seems that the callback function should be changed from parameter callback to something like rclcpp::SyncParametersClient or rclcpp::AsyncParametersClient.
Signed-off-by: vinnamkim vinnam.kim@gmail.com