[Foxy backport] Backport Publisher.topic_name #568
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the resolved_name method for publisher class Signed-off-by: Zhen Ju <juzhen@huawei.com> * Add basic test files for publisher class. Signed-off-by: Zhen Ju <juzhen@huawei.com> * Rename resolved_name to topic_name and decorate it with @Property. Update the validation for publisher handle. Signed-off-by: Zhen Ju <juzhen@huawei.com> * Improve the test on publisher topic_name property. Test the basics remapping rules and node namespace effects Signed-off-by: Zhen Ju <juzhen@huawei.com> * Handle the failure when getting topic name Fix the indentation Signed-off-by: Zhen Ju <juzhen@huawei.com> * Use multi assignment when looping test topic dicts Signed-off-by: Zhen Ju <juzhen@huawei.com> * Fix the pylint errors. Signed-off-by: Zhen Ju <juzhen@huawei.com> * Add test/test_publisher.py to pytest iters in CMakeLists Signed-off-by: Zhen Ju <juzhen@huawei.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
jacobperron
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #568 to Foxy