Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qos_policy_name_from_kind() should accept either a QoSPolicyKind or an int #637

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

ivanpauno
Copy link
Member

Fix error introduced in #634.

qos_policy_name_from_kind() was previously accepting either QoSPolicyKind or an int (which wasn't properly documented in the type annotation).
The changes introduced on that function only accepted a QoSPolicyKind, this patch reintroduce int support.

Here

policy_name = qos_policy_name_from_kind(event.last_policy_kind)

event.last_policy_kind is an int.

The error wasn't caught because fastrtps doesn't support the feature, but it the following nightlies were failing:

…n int

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the bug Something isn't working label Oct 30, 2020
@ivanpauno ivanpauno self-assigned this Oct 30, 2020
@ivanpauno
Copy link
Member Author

@ros-pull-request-builder retest this please

@ivanpauno
Copy link
Member Author

CI, testing rclpy and ros2topic with only rmw_cyclonedds available:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks okay, but not sure about the test failure.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Member Author

  • Linux Build Status

@ivanpauno
Copy link
Member Author

The change looks okay, but not sure about the test failure.

Another failure introduced in #634 that wasn't caught because of only running tests with fastrtps.

@ivanpauno ivanpauno merged commit 02fc987 into master Nov 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-qos_policy_name_from_kind branch November 2, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants