qos_policy_name_from_kind() should accept either a QoSPolicyKind or an int #637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error introduced in #634.
qos_policy_name_from_kind()
was previously accepting eitherQoSPolicyKind
or anint
(which wasn't properly documented in the type annotation).The changes introduced on that function only accepted a
QoSPolicyKind
, this patch reintroduceint
support.Here
rclpy/rclpy/rclpy/qos_event.py
Line 251 in 0a3a2bf
event.last_policy_kind
is anint
.The error wasn't caught because fastrtps doesn't support the feature, but it the following nightlies were failing: