Use Py_XDECREF for pynode_names_and_namespaces #673
Conversation
As pointed out by clang static analysis, it is possible for pynode_names_and_namespaces to be NULL during cleanup. Thus use Py_XDECREF everywhere to do that checking for us. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
Not currently, no. I've been running this locally and just fixing the bugs as I see them. The goal is indeed to have jobs available to do this either on https://ci.ros2.org, or as part of the PR jobs. |
|
The test failures on macOS are the same as in the nightlies: https://ci.ros2.org/view/nightly/job/nightly_osx_repeated/2233/#showFailuresLink . So I'm going to go ahead and merge this. Thanks for the review. |
|
Might be related to aarch64 regressions today: https://ci.ros2.org/job/nightly_linux-aarch64_repeated/1488/testReport/junit/(root)/projectroot/test_client/ ? |
I don't think so; I just merged it this morning, so it wouldn't have been used in the nightlies. |
Sorry, I meant that the problem in the nightly might have been resolved by this or do you think that the root cause is different. |
I think it is probably different; this only would be a problem during unlikely error paths. I'll suggest to open a new issue with that failure, since it is likely something different. |
As pointed out by clang static analysis, it is possible for
pynode_names_and_namespaces to be NULL during cleanup. Thus
use Py_XDECREF everywhere to do that checking for us.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org