Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pybind11 for _rclpy_action #678

Merged
merged 4 commits into from Feb 23, 2021
Merged

Use pybind11 for _rclpy_action #678

merged 4 commits into from Feb 23, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Feb 9, 2021

This uses Pybind11 for the _rclpy_action module.

Requires #667
Part of #665

@sloretz sloretz self-assigned this Feb 9, 2021
@sloretz sloretz mentioned this pull request Feb 9, 2021
34 tasks
@sloretz sloretz force-pushed the add_pybind11_dependency branch 2 times, most recently from c04dc58 to 674b02c Compare February 12, 2021 17:06
@delete-merged-branch delete-merged-branch bot deleted the branch master February 12, 2021 17:07
@sloretz sloretz changed the base branch from add_pybind11_dependency to master February 12, 2021 17:10
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz marked this pull request as ready for review February 12, 2021 17:20
@sloretz
Copy link
Contributor Author

sloretz commented Feb 23, 2021

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit f074974 into master Feb 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the pybind11_rclpy_action branch February 23, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants