👨‍🌾 rclpy fails during cmake configuration on windows CI

[azeey]

Bug report

Required Info:

• Operating System:
  • Windows 10
• Installation type:
  • source
• Version or commit hash:
  • 0ebae0c
• DDS implementation:
  • default
• Client library (if applicable):
  • rclpy

Steps to reproduce issue

rclpy is failing on CI (nightly_win_deb since build 1899) during cmake configuration. The reported error comes from ament_cmake_python while it's trying to set PYTHON_EXECUTABLE.

CMake Error at C:/ci/ws/install/share/ament_cmake_python/cmake/ament_cmake_python-extras.cmake:61 (message):
  execute_process( -c 'from distutils.sysconfig import get_python_lib;import
  os;print(os.path.relpath(get_python_lib(prefix='C:/ci/ws/install'),
  start='C:/ci/ws/install').replace(os.sep, '/'))') returned error code The
  parameter is incorrect
Call Stack (most recent call first):
  C:/ci/ws/install/share/ament_cmake_python/cmake/ament_cmake_python-extras.cmake:22 (_ament_cmake_python_get_python_install_dir)
  C:/ci/ws/install/share/ament_cmake_python/cmake/ament_python_install_package.cmake:27 (_ament_cmake_python_register_environment_hook)
  CMakeLists.txt:39 (ament_python_install_package)

Expected behavior

Builds successfully

Actual behavior

Build fails

[sloretz]

Seems likely that it was caused by #665

There's prior experience with Pybind11 issues on Windows Debug in rosbag2 that @ivanpauno solved.

ros2/rosbag2#531
ros2/rosbag2#538

I'll first try making a branch with those fixes copy/pasted to rclpy. If that fixes the issue, that should be fine until we want to update to pybind11 2.6.0. If that doesn't fix an issue, then I'll test if a revert of #665 solves the problem.