-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rosbag2_py on Windows debug and stop ignoring the package #531
Conversation
f361135
to
a3bd925
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for figuring this out 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think the yellow is the linter complaining about something. Approve on green CI
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
9b14e40
to
35fe856
Compare
Going in, thanks for the review @Karsten1987! |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Copies windows debug fixes from rosbag2_py for using Pybind11 on Windows debug and RelWithDebInfo. For more info see the original PRs ros2/rosbag2#538 ros2/rosbag2#531 Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Copies windows debug fixes from rosbag2_py for using Pybind11 on Windows debug and RelWithDebInfo. For more info see the original PRs ros2/rosbag2#538 ros2/rosbag2#531 Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
* Copy windows debug fixes for pybind11 Copies windows debug fixes from rosbag2_py for using Pybind11 on Windows debug and RelWithDebInfo. For more info see the original PRs ros2/rosbag2#538 ros2/rosbag2#531 Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Workaround for consistent Py_DEBUG macro Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * fix argument order Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Does PUBLIC Py_DEBUG resolve differences? Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Don't include Python.h if including pybind11.h Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove Py_DEBUG if target doesn't use pybind11 Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Depends on #529.Fixes #504.
This deletes the
AMENT_IGNORE
file inrosbag2_py
folder, as the two issues has been fixed now.