Remove pybind11 from rclpy common #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
Windows debug: |
|
Full CI (build:
|
clalancette
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
This seems reasonable enough to me, and clearly fixes Windows Debug. But I'm not really familiar with the transition to pybind11 here, so it is probably a good idea to get a second opinion from @hidmic before merging.
delete-merged-branch
bot
deleted the
windows_remove_pybind11_from_rclpy_common
branch
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
common.cpp/hpptoutils.cpp/hppinside the_rclpy_pybind11module. This is yet another attempt to fix windows debug.