time_until_next_call returns max if timer is canceled. #910
+43
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivanpauno @sloretz could you take a look? CC: @mauropasse |
|
CI:
|
sloretz
reviewed
Mar 8, 2022
fujitatomoya
force-pushed
the
topic-20220308-time_until_next_call
branch
from
cfba2b9
to
53a215e
Compare
fujitatomoya
commented
Mar 10, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
force-pushed
the
topic-20220308-time_until_next_call
branch
from
53a215e
to
159c95c
Compare
|
CI:
|
|
@sloretz @ivanpauno friendly ping. |
|
i do not see failure https://ci.ros2.org/job/ci_linux/16309/console on my local environment, but i think header is missing in hpp file. |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-Authored-By: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
CI:
|
|
windows failure is unrelated to this fix. |
apockill
pushed a commit
to apockill/rclpy
that referenced
this pull request
Mar 16, 2022
* time_until_next_call returns None if timer is canceled. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-Authored-By: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: Alex Thiel <apocthiel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aligned with ros2/rcl#963 and ros2/rclcpp#1893
Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com