Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time_until_next_call returns max if timer is canceled #907

Closed
wants to merge 1 commit into from
Closed

time_until_next_call returns max if timer is canceled #907

wants to merge 1 commit into from

Conversation

mauropasse
Copy link

The PR ros2/rcl#963 changes rcl_timer_get_time_until_next_call to return RCL_RET_TIMER_CANCELED if timer was canceled.
Here in rclpy we'll return std::numeric_limits<int64_t>::max() on time_until_next_call if timer was canceled.

Signed-off-by: Mauro Passerino mpasserino@irobot.com

time_until_next_call returns max if timer is canceled
78b0d88 
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
@mauropasse mauropasse mentioned this pull request Mar 2, 2022
Merged
fujitatomoya
fujitatomoya approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nicer if we have doc section aligned with rclcpp, but lgtm.

@mauropasse mauropasse closed this Mar 11, 2022
@mauropasse
Copy link
Author

#910 did the job, thanks @fujitatomoya !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauropasse @fujitatomoya