executor.add_node() returns a bool #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
added
bug
|
CI
|
dirk-thomas
reviewed
Aug 8, 2018
| @@ -230,6 +230,12 @@ def __await__(self): | |||
| rclpy.spin_once(self.node, timeout_sec=0) | |||
| self.assertTrue(did_return) | |||
|
|
|||
| def test_executor_add_node(self): | |||
| self.assertIsNotNone(self.node.handle) | |||
There was a problem hiding this comment.
I see that this matches the style in this file but in general we should use a plain assert instead (the recommended way with pytest). Nothing needs to happen for this patch though...
There was a problem hiding this comment.
Roger. I'll make sure to use a plain assert in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
executor.add_node()says it returnsTrueif the node was added; however it currently just returnsNone. This fixes the function, and also makes it so the guard condition to rebuild the waitset is only triggered if the node really was added.