Fix time conversion for a big nanoseconds value #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change from the floating constant value(1e9) to the integer constant value(10 ** 9) Signed-off-by: vinnamkim <vinnam.kim@gmail.com>
sloretz
reviewed
Jul 8, 2019
Signed-off-by: vinnamkim <vinnam.kim@gmail.com>
|
CI (testing just rclpy)
|
sloretz
pushed a commit
that referenced
this pull request
Aug 23, 2019
* Fix time conversion for a big nanoseconds value - Change from the floating constant value(1e9) to the integer constant value(10 ** 9) Signed-off-by: vinnamkim <vinnam.kim@gmail.com> * Removed unrelated test Signed-off-by: vinnamkim <vinnam.kim@gmail.com>
sloretz
pushed a commit
that referenced
this pull request
Aug 23, 2019
* Fix time conversion for a big nanoseconds value - Change from the floating constant value(1e9) to the integer constant value(10 ** 9) Signed-off-by: vinnamkim <vinnam.kim@gmail.com> * Removed unrelated test Signed-off-by: vinnamkim <vinnam.kim@gmail.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
that referenced
this pull request
Aug 24, 2019
* Fix time conversion for a big nanoseconds value - Change from the floating constant value(1e9) to the integer constant value(10 ** 9) Signed-off-by: vinnamkim <vinnam.kim@gmail.com> * Removed unrelated test Signed-off-by: vinnamkim <vinnam.kim@gmail.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #293
Signed-off-by: vinnamkim vinnam.kim@gmail.com