Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the rcl_action return value on cleanup. #672

Merged
merged 4 commits into from Feb 3, 2021
Merged

Check the rcl_action return value on cleanup. #672

merged 4 commits into from Feb 3, 2021

Commits on Feb 1, 2021

  1. Check the rcl_action return value on cleanup. 

    And add an error message as appropriate.  clang static
analysis pointed out that this was a dead store.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    ed79e46 View commit details
    Browse the repository at this point in the history

  2. Ensure that we keep the original error. 

    As sloretz pointed out, the pointer we were keeping to the
original error would get overwritten with the next error,
so we really need a copy.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    f3e340a View commit details
    Browse the repository at this point in the history

  3. Use copy-assignment for original_error. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    57427a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Remove unnecessary include. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    3038019 View commit details
    Browse the repository at this point in the history