Use py::class_ for rmw_qos_profile_t #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll rebase once #739 goes in. |
34 tasks
sloretz
approved these changes
Mar 31, 2021
hidmic
force-pushed
the
hidmic/pybind-rmw-qos-profile
branch
from
7e4239a
to
cb1ec86
Compare
|
CI up to
|
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/pybind-rmw-qos-profile
branch
from
65e60b6
to
0d1b355
Compare
|
@ros-pull-request-builder retest this please. |
|
CI up to
|
|
@ros-pull-request-builder retest this please. |
|
Alright CI and reviewers are happy. Going in! |
emersonknapp
pushed a commit
to ros2/rosbag2
that referenced
this pull request
Apr 1, 2021
Change introduced by ros2/rclpy#741 conflicted with parallel work in #702, the combination causing nightly test failure for `rosbag2_py`'s `_transport.cpp` tests. Fix to use the new `py::object` for `rmw_qos_profile_t` to fix the tests. Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
pushed a commit
to ros2/rosbag2
that referenced
this pull request
Apr 1, 2021
Change introduced by ros2/rclpy#741 conflicted with parallel work in #702, the combination causing nightly test failure for `rosbag2_py`'s `_transport.cpp` tests. Fix to use the new `py::object` for `rmw_qos_profile_t` to fix the tests. Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
added a commit
to ros2/rosbag2
that referenced
this pull request
Apr 1, 2021
* Fix rosbag2_py transport test for py capsule Change introduced by ros2/rclpy#741 conflicted with parallel work in #702, the combination causing nightly test failure for `rosbag2_py`'s `_transport.cpp` tests. Fix to use the new `py::object` for `rmw_qos_profile_t` to fix the tests. Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Kettenhoax
pushed a commit
to Kettenhoax/rosbag2
that referenced
this pull request
Apr 9, 2021
* Fix rosbag2_py transport test for py capsule Change introduced by ros2/rclpy#741 conflicted with parallel work in ros2#702, the combination causing nightly test failure for `rosbag2_py`'s `_transport.cpp` tests. Fix to use the new `py::object` for `rmw_qos_profile_t` to fix the tests. Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #665. Precisely what the title says. This data structure remains opaque, as it is redundant with those found in
qos.py. I still feel the urge to rewriteqos.pyin full, but I'll hold back.