Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow declaring uninitialized parameters #798

Merged
merged 7 commits into from
May 19, 2021
Merged

Allow declaring uninitialized parameters #798

merged 7 commits into from
May 19, 2021

Commits on May 18, 2021

  1. Allow declaring uninitialized parameters 

    Parameters can now be declared without a default value and without an override.
Attempting to access a statically typed parameter that does not have value will raise an exception.
Getting dynamically typed parameters will return an unset parameter value.

This change is equivalent to that made in rclcpp: ros2/rclcpp#1673

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed May 18, 2021
    Configuration menu
    Copy the full SHA
    6226539 View commit details
    Browse the repository at this point in the history

  2. Fix flake8 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed May 18, 2021
    Configuration menu
    Copy the full SHA
    c589221 View commit details
    Browse the repository at this point in the history

  3. Minor refactor 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed May 18, 2021
    Configuration menu
    Copy the full SHA
    5aeceba View commit details
    Browse the repository at this point in the history

  4. Don't allow static parameters to be undeclared 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed May 18, 2021
    Configuration menu
    Copy the full SHA
    5e8266f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Return alternative for uninitialized parameters in get_parameter_or 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed May 19, 2021
    Configuration menu
    Copy the full SHA
    38f85c3 View commit details
    Browse the repository at this point in the history

  2. Ditto for dynamic parameters 

    This is the same behavior as rclcpp.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed May 19, 2021
    Configuration menu
    Copy the full SHA
    763ef63 View commit details
    Browse the repository at this point in the history

  3. Fix lint 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed May 19, 2021
    Configuration menu
    Copy the full SHA
    1dda921 View commit details
    Browse the repository at this point in the history