Add clamp header

[v-lopez]

Avoids temporarily avoids using boost or C++17

In the end I did not need to create another library target for this, since all templates. But I've put in the separate directory as discussed.

Fixes #84

[Karsten1987]

This looks good to me, but I guess it deserves a bit more doxygen. It would be great if you could come up with something similar to what is done in other headers, e.g.: https://github.com/ros2/rcpputils/blob/master/include/rcpputils/join.hpp#L30-L39

[Karsten1987]

• Linux
• Linux-aarch64
• macOS
• Windows

[emersonknapp]

That is my only feedback as well, to more thoroughly document the functions provided. Thanks for this contribution!

[v-lopez]

Sure, I'll do it tomorrow morning.

[emersonknapp]

Also note that you will need to use git commit --signoff to pass the DCO check. You can do this for existing commits with git rebase --signoff -i origin/master and leaving all the commits as pick

[v-lopez]

I've addressed the documentation and signing, please take a look when you have time.

[emersonknapp]

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

@emersonknapp can this be merged? Ideally we'd like to have this backported to Foxy as well to have ros_control still be compatible with Foxy.

[wjwwood]

Uh, I just saw this in the include folder. What's the rationale for putting this in a different namespace from rcpputils?

We have a pretty consistent pattern of having the root cpp namespaces (and include namespace to match) be the same as the package name.

In my opinion, this should be moved into the rcpputils namespace.

[v-lopez]

It was done in a separate namespace after discussion in #84, in case in the future similar functions are added and this ends up on a separate package or structure.

[wjwwood]

I see, thanks for the pointer @v-lopez, but I have to really disagree with the direction. I think it should be in the rcpputils namespace until it is split into a separate package. Splitting it preemptively is just confusing to me.

I'll probably make pull requests to move it in rolling and deprecate it and provide the new location in foxy, unless someone convinces me otherwise. @emersonknapp @clalancette?

[clalancette]

I'll probably make pull requests to move it in rolling and deprecate it and provide the new location in foxy, unless someone convinces me otherwise. @emersonknapp @clalancette?

That sounds good to me.