Assume WIN32 HINSTANCE is a void * #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to MSDN, `HINSTANCE` is a `HANDLE` is a `PVOID` is a `void *` everywhere on Windows. If we assume this, we can drop the problematic Windows.h include from our header and contain it to a single source file. I included a sanity check that will break if this assumption is ever broken. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
remove_windows_h
branch
from
1b7ddd4
to
e2ad26e
Compare
dirk-thomas
approved these changes
Apr 9, 2020
|
The Windows test failures were appearing on nightly builds a few days ago, so I don't believe that this change regressed them. |
jacobperron
added a commit
that referenced
this pull request
Apr 10, 2020
This reverts commit a6306c6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MSDN,
HINSTANCEis aHANDLEis aPVOIDis avoid *everywhere on Windows. If we assume this, we can drop the problematic Windows.h include from our header and contain it to a single source file.I included a sanity check that will break if this assumption is ever broken.
Alternative to #229
Inspired by ros2/geometry2#247