Add in a concurrent test to test_logging_output_format.py #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, there was only a post_shutdown_test. Due to a bug in launch_testing, having only a post_shutdown test causes stack traces to be printed while starting up the tests. Add in this workaround to quiet the problem until the bug is fixed. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
|
Green CI is above, so I'm going to go ahead and merge this. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, there was only a post_shutdown_test. Due
to a bug in launch_testing, having only a post_shutdown test
causes stack traces to be printed while starting up the tests.
Add in this workaround to quiet the problem until the bug
is fixed.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Fixes #204