Include node namespaces in get_node_names() #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Aug 28, 2018
| @@ -473,7 +473,8 @@ RMW_WARN_UNUSED | |||
| rmw_ret_t | |||
| rmw_get_node_names( | |||
| const rmw_node_t * node, | |||
| rcutils_string_array_t * node_names); | |||
| rcutils_string_array_t * node_names, | |||
| rcutils_string_array_t * node_namespaces); | |||
There was a problem hiding this comment.
With the signature becoming more complicated can you please add a docblock to document the semantic of these arguments.
|
dirk-thomas
approved these changes
Aug 29, 2018
rmw/include/rmw/rmw.h
Outdated
| /** | ||
| * This function will return a list of node names and a list of node namespaces | ||
| * that are discovered via the middleware. The list of names and namespaces | ||
| * will be the same length. |
There was a problem hiding this comment.
While kind of obvious maybe the doc should be explicit that these two lists represent pairs of namespace and name for each node.
wjwwood
approved these changes
Aug 29, 2018
| @@ -468,12 +468,40 @@ rmw_wait( | |||
| rmw_wait_set_t * wait_set, | |||
| const rmw_time_t * wait_timeout); | |||
|
|
|||
| /// Return a list of node name and namespaces discovered via a node. | |||
There was a problem hiding this comment.
nitpick: either node names and namespaces or node name and namespace pairs?
mjcarroll
force-pushed
the
get_node_names_and_namespaces
branch
from
3992257
to
1292dd2
Compare
|
Enough changes to justify running CI again:
|
|
|
I fixed the new warnings in |
dabonnie
pushed a commit
to aws-ros-dev/rmw
that referenced
this pull request
Apr 2, 2019
* Include node namespaces in get_node_names(). * Update documentation for get_node_names. * Refinement/clarification of documentation. * wrap after sentence Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #142