Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in inconsistent topic defines and data structures. #339

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Add in inconsistent topic defines and data structures. #339

merged 2 commits into from
Mar 13, 2023

Conversation

clalancette
Copy link
Contributor

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Part of ros2/ros2#1361

@ivanpauno
Copy link
Member

what's the equivalent event in DDS?

@ivanpauno
Copy link
Member

Found it: https://community.rti.com/static/documentation/connext-dds/5.3.0/doc/manuals/connext_dds/html_files/RTI_ConnextDDS_CoreLibraries_UsersManual/Content/UsersManual/INCONSISTENT_TOPIC_Status.htm

ivanpauno
ivanpauno approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have one comment

rmw/include/rmw/events_statuses/inconsistent_topic.h Outdated Show resolved Hide resolved
@clalancette clalancette self-assigned this Jan 5, 2023
@clalancette clalancette mentioned this pull request Jan 24, 2023
Merged
@clalancette clalancette force-pushed the clalancette/inconsistent-topic-event branch from cea020e to e799e86 Compare January 24, 2023 18:19
@clalancette clalancette force-pushed the clalancette/inconsistent-topic-event branch from e799e86 to 617265f Compare February 3, 2023 16:52
@clalancette clalancette force-pushed the clalancette/inconsistent-topic-event branch from 617265f to 480fa61 Compare February 10, 2023 16:50
@clalancette clalancette force-pushed the clalancette/inconsistent-topic-event branch from 480fa61 to 17f884f Compare February 24, 2023 21:07
This was referenced Feb 28, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@clalancette
Add in inconsistent topic defines and data structures.
cb2860e 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Switch name to incompatible type.
8f1d9ef 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette force-pushed the clalancette/inconsistent-topic-event branch from 17f884f to 8f1d9ef Compare March 10, 2023 14:53
@clalancette clalancette merged commit 949f410 into rolling Mar 13, 2023
@clalancette clalancette deleted the clalancette/inconsistent-topic-event branch March 13, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@methylDragon methylDragon methylDragon approved these changes

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clalancette @ivanpauno @methylDragon @fujitatomoya