Switch to using new event_handler instead of qos_event. #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
approved these changes
Jan 8, 2023
clalancette
force-pushed
the
clalancette/inconsistent-topic-event
branch
from
3e9ab14
to
5e0dbf0
Compare
gbiggs
approved these changes
Jan 22, 2023
clalancette
force-pushed
the
clalancette/inconsistent-topic-event
branch
from
5e0dbf0
to
775997a
Compare
clalancette
force-pushed
the
clalancette/inconsistent-topic-event
branch
2 times, most recently
from
505a508
to
f0ccc08
Compare
clalancette
force-pushed
the
clalancette/inconsistent-topic-event
branch
2 times, most recently
from
4ff95e5
to
3d0c71d
Compare
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
clalancette/inconsistent-topic-event
branch
from
3d0c71d
to
b030906
Compare
delete-merged-branch
bot
deleted the
clalancette/inconsistent-topic-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This is part of ros2/ros2#1361
qos_event was deprecated inside of rclpy in ros2/rclpy#1058 , so use the new API names in this PR.
Part of ros2/ros2#1361
Depends on ros2/rmw#339
Depends on ros2/rcl#1024
Depends on ros2/rclpy#1058