-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hash to rmw_topic_endpoint_info_t (rep2011) #348
Add type hash to rmw_topic_endpoint_info_t (rep2011) #348
Conversation
ec88eaf
to
2524e0a
Compare
5e82fe0
to
4795cca
Compare
@wjwwood @methylDragon @ivanpauno this is ready for review, the types are finalized in the dependency PR, we're only hashing out final details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing to fix here, then I think this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with green CI.
Now that ros2/rosidl#722 is merged, we can run CI on this one alone and merge it in: CI: |
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
049a83b
to
04f9e43
Compare
The test failures on Windows are known flakes. So going ahead and merging this one in. |
Part of ros2/ros2#1159
Depends on ros2/rosidl#722
Adds
topic_type_hash
field tormw_topic_endpoint_info_t
so that it can be filled by RMW implementations.