-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hash distribution in discovery (rep2011) #671
Type hash distribution in discovery (rep2011) #671
Conversation
326cc22
to
b1967cd
Compare
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_participant_info.hpp
Outdated
Show resolved
Hide resolved
rmw_fastrtps_shared_cpp/test/test_rmw_qos_to_dds_attributes.cpp
Outdated
Show resolved
Hide resolved
ec3df77
to
37b65f6
Compare
4cc09ad
to
2fb92a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left two more things I think should be changed. Otherwise this looks good to me.
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_participant_info.hpp
Show resolved
Hide resolved
Same run combined for PRs ros2/rmw_dds_common#70 #671 ros2/rmw_cyclonedds#437 ros2/rmw_connextdds#104 Gist: https://gist.githubusercontent.com/emersonknapp/597121a37b82d9418b14472de760c8f0/raw/b0412d81c2ae2368cb592c810496d6f92650ad68/ros2.repos |
4aa2acb
to
ba7eaf6
Compare
@@ -314,7 +314,9 @@ rmw_create_client( | |||
reader_qos.data_sharing().off(); | |||
} | |||
|
|||
if (!get_datareader_qos(adapted_qos_policies, reader_qos)) { | |||
if (!get_datareader_qos( | |||
adapted_qos_policies, *type_supports->response_typesupport->type_hash, reader_qos)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: I don't know if this package has our linters run over it, but I would have expected this to use two spaces of indent, not four
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linters did run - your intuition is my intuition, but uncrustify
wants it this way. I believe the logic is "2 times the number of opening braces" - in this case there's if ((
so it expects 4 spaces
rmw_fastrtps_shared_cpp/test/test_rmw_qos_to_dds_attributes.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
b6a69f2
to
40afb80
Compare
Gist: https://gist.githubusercontent.com/emersonknapp/c36ca5985030eccbcaac0d0384236fbd/raw/374f6ef848452efc7e6a2b079129195ece75aeec/ros2.repos |
CI is in ros2/rmw_dds_common#70 (comment) |
Part of ros2/ros2#1159
Depends on ros2/rmw_dds_common#70
Depends on ros2/rosidl#729
Features:
rmw_dds_common
rmw_topic_endpoint_info_t.type_hash