-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend rmw_serialized_message_t tests. #261
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for two minor comments.
rmw/test/test_serialized_message.cpp
Outdated
rmw_serialized_message_t serialized_message = | ||
rmw_get_zero_initialized_serialized_message(); | ||
rcutils_allocator_t default_allocator = rcutils_get_default_allocator(); | ||
size_t serialized_message_size = 5lu; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constexpr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in a5c92af.
rmw/test/test_serialized_message.cpp
Outdated
EXPECT_EQ(1u << i, serialized_message.buffer[i]); | ||
} | ||
|
||
size_t serialized_message_new_size = 2 * serialized_message_size; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constexpr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in a5c92af.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Going in! |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Precisely what the title says. Follow-up after #258