remove shared flag from rmw library declaration #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will we need a corresponding change to ament in order to keep the default behavior |
|
@dirk-thomas is the expert; I'm not sure if ament already sets the default library type... |
|
It does currently not set anything when invoking CMake. |
|
we probably need to create our own ament flag for "what kind of library do you want" that defaults to SHARED, and then always pass that flag in to CMake, so that we don't have it hard-wired in the CMakeLists, but yet get shared libraries by default. |
|
I implemented the behavior that @codebot described, in ament/ament_tools#128 and removed the |
|
Superseded by #98. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by removing the SHARED keyword from the add_library call, we can set it externally and thus allow the cmake machinery to select between shared or static builds.