Control shared/static linking via BUILD_SHARED_LIBS #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
added
in progress
This was referenced Dec 22, 2016
|
This PR works as-is so I will go ahead and merge it (while some other related PRs are still pending). |
|
Thanks! |
|
I reverted the merge since it actually fails on Windows and fails tests on Linus (even when using the default of shared libraries). |
|
@esteve Can you please look into the problems and create a new PR which passes. |
emersonknapp
pushed a commit
to aws-ros-dev/rcl
that referenced
this pull request
Jun 3, 2019
ivanpauno
pushed a commit
that referenced
this pull request
Jan 2, 2020
* rename rmw_topic_validation_result_string() * fix length checking test * add rmw_validate_node_name() * return NULL when the name is valid (topic and node)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR delegates the decision to build a shared or a static library to CMake's
BUILD_SHARED_LIBSUpdate:
Connects to ros2/ros2#306