Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

[Backport Foxy] Included improvements to increase code coverage #255 #469

Merged
merged 22 commits into from Oct 15, 2020
Merged

[Backport Foxy] Included improvements to increase code coverage #255 #469

merged 22 commits into from Oct 15, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 9, 2020

This PR depends on:

Included error checks, return the right code errors, avoid crashes, etc

hidmic and others added 21 commits October 8, 2020 15:07
@hidmic @ahcorde
Finalize context if and only if it's shutdown (#428)
a56d519 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Ensure compliant init options API implementations. (#431)
82bde62 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Ensure compliant init/shutdown API implementation. (#432)
21da7b3 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Amend rmw_init() implementation: require enclave. (#437)
d5f840f 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Ensure compliant node construction/destruction API. (#439)
04ac23c 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Ensure compliant publisher API (#445)
4a3507c 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Decouple rmw_destroy_publisher() outcome from global RMW error state. (…
26116fb 
…#449)

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Ensure compliant subscription API. (#450)
539f8d3 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Ensure compliant matched pub/sub count API. (#451)
c446b63 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@Lobotuerk @ahcorde
Update rmw_publish_serialized_message() error returns (#453)
56c955f 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk @ahcorde
Update rmw_publish() error returns (#452)
79aa76f 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk @Blast545 @ahcorde
Updated error returns on rmw_take (#454)
60e7796 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>

Co-authored-by: Jorge Perez <jjperez@ekumenlabs.com>
@Lobotuerk @ahcorde
updated error returns (#456)
7043ecc 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@hidmic @ahcorde
Update graph API return codes. (#459)
c02c8fc 
This patch affects:
- rmw_get_node_names()
- rmw_get_node_names_with_enclaves()
- rmw_get_topic_names_and_types()
- rmw_get_service_names_and_types()
- rmw_get_publishers_info_by_topic()
- rmw_get_subscriptions_info_by_topic()
- rmw_get_subscriber_names_and_types_by_node()
- rmw_get_publisher_names_and_types_by_node()
- rmw_get_service_names_and_types_by_node()
- rmw_get_client_names_and_types_by_node()
- rmw_count_publishers()
- rmw_count_subscribers()

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Update gid API return codes. (#461)
b1248c6 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@Lobotuerk @ahcorde
Updated returns on rmw_take_serialized_with_info (#462)
57f7335 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@hidmic @ahcorde
Update service/client construction/destruction API return codes. (#464)
c18a94d 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@ahcorde
Updated rmw_* return codes (#463)
c234ff3 
* Updated rmw_*_*_allocation return codes

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed error codes in rmw_wait and rmw_destroy_wait

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Used RMW_CHECK_ARGUMENT_FOR_NULL

Signed-off-by: ahcorde <ahcorde@gmail.com>
@Lobotuerk @ahcorde
Update service/client request/response API error returns (#465)
db2cb85 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@ahcorde
returned RMW_RET_INCORRECT_RMW_IMPLEMENTATION in rmw_service_server_i…
ed39f59 
…s_available (#466)

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Return RMW_RET_UNSUPPORTED in rmw_get_serialized_message_size (#467)
b8f22d5 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from brawner October 9, 2020 07:43
@ahcorde ahcorde self-assigned this Oct 9, 2020
@ahcorde ahcorde mentioned this pull request Oct 9, 2020
Merged
brawner
brawner approved these changes Oct 9, 2020
View reviewed changes
Copy link

@brawner brawner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update your title and description, this PR doesn't affect code coverage and just includes bug fixes for various files.

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 13, 2020

@ros-pull-request-builder retest this please

@ahcorde
Fixed Foxy
e159967 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 14, 2020 •
edited

Compiled up-to rmw_connext_cpp rmw_connext_shared_cpp and tested rmw_connext_cpp rmw_connext_shared_cpp

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 15, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit aa927e0 into foxy Oct 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/backport/foxy branch October 15, 2020 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brawner brawner brawner approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahcorde @brawner @hidmic @Lobotuerk