Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Mitigate discovery race condition between clents and services" #146

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Apr 6, 2024

Reverts #132

This seems to be causing regressions on Windows; see #132 (comment) .

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • Windows Debug Build Status

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette i agree, lets revert this.

@clalancette clalancette merged commit 0399872 into rolling Apr 6, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the revert-132-asorbini/service-discovery-race branch April 6, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants