rmw_cyclonedds_cpp/CMakeLists.txt: add -latomic for RISC-V #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
guillaume-pais-siemens
changed the title
guillaume-pais-siemens
changed the title
ivanpauno
approved these changes
Aug 26, 2021
|
ci.ros2.org is currently down, I will run CI when it gets back |
|
CI:
|
|
My bad, I ran CI using the wrong branch.
|
|
third time's the charm:
|
|
|
Finally ... It seems that macOS has issues when -latomic is passed and windows shows a warning as well. |
|
ivanpauno
approved these changes
Aug 30, 2021
|
Thanks @guillaume-pais-siemens !! |
|
@Mergifyio backport foxy galactic |
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2021
(cherry picked from commit 91646ce)
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2021
(cherry picked from commit 91646ce)
|
Command
|
ivanpauno
pushed a commit
that referenced
this pull request
Aug 30, 2021
ivanpauno
pushed a commit
that referenced
this pull request
Aug 30, 2021
clalancette
pushed a commit
to eboasson/rmw_cyclonedds
that referenced
this pull request
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ivan Santiago Paunovic ivanpauno@ekumenlabs.com
See Pull Request: add -latomic in CMakelist.txt #327