Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rmw_publisher_wait_for_all_acked support #294

Merged

Conversation

Barry-Xu-2018
Copy link
Contributor

Related to ros2/rmw#295

Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll do the trick. LGTM!

@Barry-Xu-2018 Barry-Xu-2018 force-pushed the topic-wait_for_all_acked-feature branch from fc27236 to e65e103 Compare April 16, 2021 09:37
@Barry-Xu-2018
Copy link
Contributor Author

Do rebase.

@Barry-Xu-2018 Barry-Xu-2018 force-pushed the topic-wait_for_all_acked-feature branch from e65e103 to ae7f348 Compare May 30, 2021 07:58
@Barry-Xu-2018
Copy link
Contributor Author

Do rebase

@Barry-Xu-2018
Copy link
Contributor Author

The failure is caused by build error

15:59:18 /tmp/ws/src/rmw_cyclonedds/rmw_cyclonedds_cpp/src/rmw_node.cpp:1650:67:   required from here
15:59:18 /tmp/ws/src/rmw_cyclonedds/rmw_cyclonedds_cpp/src/rmw_node.cpp:1167:35: error: ‘dds_data_allocator_init_heap’ was not declared in this scope; did you mean ‘dds_data_allocator_init’?

But codes aren't related to this change.
I will rebase code and trigger CI again.

Signed-off-by: Barry Xu <barry.xu@sony.com>
@ivanpauno
Copy link
Member

Tests were run in ros2/rmw#296

@ivanpauno ivanpauno merged commit e6876a2 into ros2:master Jun 15, 2021
clalancette pushed a commit to eboasson/rmw_cyclonedds that referenced this pull request May 18, 2022
Signed-off-by: Barry Xu <barry.xu@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants