Fix compiler warnings with Iceoryx #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g SHM Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
|
Thanks for the update here. I'm going to wait to run CI on this until we also get the fix for CUnit being required in CycloneDDS merged. Once that is merged, I'll run CI on this PR, ros2/ros2#1128 , and that CUnit fix all together. |
|
Minimal CI (
|
|
For now I'm going to remove ros2/ros2#1128, and try minimal CI again:
|
|
All right, that's happy. Here's full CI with this PR and eclipse-cyclonedds/cyclonedds#758:
|
hidmic
approved these changes
Apr 9, 2021
clalancette
approved these changes
Apr 9, 2021
|
The 4 failures on macOS are known-flakey tests. Everything else is green. 2 approvals. Thanks for the fix, merging. |
eboasson
pushed a commit
to eboasson/rmw_cyclonedds
that referenced
this pull request
May 17, 2021
…g SHM (ros2#300) Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
clalancette
pushed a commit
to eboasson/rmw_cyclonedds
that referenced
this pull request
May 18, 2022
…g SHM (ros2#300) Signed-off-by: Sumanth Nirmal <sumanth.724@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to use the macros directly from Cyclone DDS to work with the payload sample when using SHM