Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing RMW functions #14

Closed
jacquelinekay opened this issue Feb 9, 2016 · 4 comments
Closed

Implement missing RMW functions #14

jacquelinekay opened this issue Feb 9, 2016 · 4 comments
Assignees
Labels
in review Waiting for review (Kanban column)

Comments

@jacquelinekay
Copy link
Contributor

The following functions in src/functions.cpp are not implemented yet:

https://github.com/eProsima/ROS-RMW-Fast-RTPS-cpp/blob/master/rmw_fastrtps_cpp/src/functions.cpp#L1770-L1806

We haven't exercised these functions outside of the ros1bridge yet, but this limitation came up recently in ros2/system_tests#103.

@JaimeMartin
Copy link
Contributor

Hi Jackie,

We are working on this. We will keep you posted.

@jacquelinekay
Copy link
Contributor Author

Thanks!

Pinging @wjwwood too since I believe he needs this for his work on the Graph API.

@richiprosima
Copy link
Contributor

service_is_available functionality for Fast-RTPS in #56.
@wjwwood I noticed that function wait_for_service calls only one time to rmw_service_is_available function. It should test more times, shouldn't it?

@wjwwood
Copy link
Member

wjwwood commented Sep 15, 2016

@richiprosima rmw_service_is_available is a non-blocking call, so no it only checks once. The idea is that you're waiting for changes to the graph and only call this function once at the beginning and once each time the graph changes, until it either returns true or you've waited as long as you're willing to wait. See the implementation for wait_for_service in rclcpp:

https://github.com/ros2/rclcpp/blob/4e74edf8d43f57497f98fe27a1f011c8857b918c/rclcpp/src/rclcpp/client.cpp#L65-L108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

No branches or pull requests

4 participants