Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated code #637

Merged

Conversation

Barry-Xu-2018
Copy link
Contributor

@Barry-Xu-2018 Barry-Xu-2018 commented Sep 27, 2022

Find duplicated code and remove it.

fastdds_wait_set->detach_condition(custom_event_info->get_listener()->get_statuscondition());

is the same as the following code

eprosima::fastdds::dds::StatusCondition & status_condition =
    custom_event_info->get_listener()->get_statuscondition();
fastdds_wait_set->detach_condition(status_condition);

Signed-off-by: Barry Xu <barry.xu@sony.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@iuhilnehc-ynos
Copy link
Contributor

iuhilnehc-ynos commented Sep 28, 2022

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Contributor

@iuhilnehc-ynos iuhilnehc-ynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gray icon to approve. (no authority to merge this PR)

@clalancette clalancette merged commit a7601e6 into ros2:rolling Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants