fix listener locking #147
Merged
fix listener locking #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dirk-thomas
added
in review
dirk-thomas
force-pushed
the
fix_listener_locking
branch
from
69698d1
to
e31debd
Compare
|
Just a set of "standard" builds:
@dhood Maybe you can trigger some builds which cover some specific tests previously flaky with a larger number of test repetitions. |
This was referenced Aug 22, 2017
|
CI retesting only
|
|
Nice! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhood and I have been looking at the deadlocks some more together and finally figured out that #132 (comment) introduced a regression (more details there).
Hopefully this patch will cover #142 as well a #143.
馃憦 goes to @dhood for figuring out all these cases and working on the fixes.