Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid memory leaks and undefined behavior in rmw_fastrtps_dynamic_cpp typesupport code #429

Merged
merged 7 commits into from
Sep 9, 2020
Merged

Avoid memory leaks and undefined behavior in rmw_fastrtps_dynamic_cpp typesupport code #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
916b58d
Get rid of call_new
MiguelCompany Sep 4, 2020
9183e57
Use resize_function and get_function on sequences and arrays.
MiguelCompany Sep 4, 2020
e547be4
Fixed linters
MiguelCompany Sep 7, 2020
1c32f41
Use static_cast on sub_members
MiguelCompany Sep 8, 2020
82a6335
Use size_function and get_function when serializing.
MiguelCompany Sep 8, 2020
5725136
Use size_function and get_function on getEstimatedSerializedSize.
MiguelCompany Sep 8, 2020
ccb1590
Removed unused code.
MiguelCompany Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions rmw_fastrtps_dynamic_cpp/include/rmw_fastrtps_dynamic_cpp/TypeSupport.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ struct StringHelper<rosidl_typesupport_introspection_c__MessageMembers>
return std::string(data.data);
}

static void assign(eprosima::fastcdr::Cdr & deser, void * field, bool)
static void assign(eprosima::fastcdr::Cdr & deser, void * field)
{
std::string str;
deser >> str;
Expand All @@ -120,12 +120,9 @@ struct StringHelper<rosidl_typesupport_introspection_cpp::MessageMembers>
return *(static_cast<std::string *>(data));
}

static void assign(eprosima::fastcdr::Cdr & deser, void * field, bool call_new)
static void assign(eprosima::fastcdr::Cdr & deser, void * field)
{
std::string & str = *(std::string *)field;
if (call_new) {
new(&str) std::string;
}
deser >> str;
}
};
Expand Down Expand Up @@ -195,8 +192,7 @@ class TypeSupport : public BaseTypeSupport
bool deserializeROSmessage(
eprosima::fastcdr::Cdr & deser,
const MembersType * members,
void * ros_message,
bool call_new) const;
void * ros_message) const;
};

} // namespace rmw_fastrtps_dynamic_cpp
Expand Down
Loading