Add node construction/destruction API test coverage. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API documentation is a bit vague. Tests fail for all main RMW implementations, either in a SIGSEGV or a SIGABRT. |
hidmic
force-pushed
the
hidmic/rmw-node-construction-destruction-tests
branch
from
7bcced2
to
9edb819
Compare
|
Depends on #113. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/rmw-node-construction-destruction-tests
branch
from
fd4b69c
to
4e223d3
Compare
hidmic
changed the title
|
Running CI up to
|
brawner
approved these changes
Jul 14, 2020
| EXPECT_EQ(nullptr, node); | ||
| rmw_reset_error(); | ||
|
|
||
| const char * const invalid_name = "foo bar"; |
There was a problem hiding this comment.
nit: instead of invalid_name, rename to 'name_with_spaces' to communicate why it's an invalid name.
Blast545
approved these changes
Jul 14, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/rmw-node-construction-destruction-tests
branch
from
ab555d2
to
23decd6
Compare
|
@ros-pull-request-builder retest this please. |
1 similar comment
|
@ros-pull-request-builder retest this please. |
|
Alright, all green! Merging. |
delete-merged-branch
bot
deleted the
hidmic/rmw-node-construction-destruction-tests
branch
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 21, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at testing
rmw_create_node()andrmw_destroy_node().