Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that rmw_init() fails if no enclave is given. #113

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Check that rmw_init() fails if no enclave is given. #113

merged 1 commit into from
Jul 9, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jul 6, 2020

Connected to ros2/rmw#247.

@hidmic
Check that rmw_init() fails if no enclave is given.
361b319 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested review from brawner and Blast545 July 6, 2020 20:25
@hidmic
Copy link
Contributor Author

hidmic commented Jul 6, 2020 •
edited
Loading

Running CI up to test_rmw_implementation and all RMW implementations:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Blast545
Blast545 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@Blast545 Blast545 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test_rmw_implementation/test/test_init_shutdown.cpp Show resolved Hide resolved
@hidmic hidmic mentioned this pull request Jul 7, 2020
Merged
@jacobperron
Copy link
Member

@ros-pull-request-builder retest this please

@jacobperron jacobperron mentioned this pull request Jul 9, 2020
Merged
@dirk-thomas
Copy link
Member

@ros-pull-request-builder retest this please

jacobperron
jacobperron approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm going to go ahead and merge this now that the PR job is happy.

@jacobperron jacobperron merged commit 678f2c6 into master Jul 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/require-enclave branch July 9, 2020 21:13
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
@hidmic @ahcorde
Check that rmw_init() fails if no enclave is given. (#113)
63c50a0 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 21, 2020
@hidmic @ahcorde
Check that rmw_init() fails if no enclave is given. (#113)
d7795e0 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

@brawner brawner brawner approved these changes

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hidmic @jacobperron @dirk-thomas @brawner @Blast545