Accept any RMW implementation, not just the default #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'get_default_rmw_implementation' macro contains the same functionality as is removed by this change, but it contains logic to fall back to any available RMW implementation if neither RMW_IMPLEMENTATION is specified nor the default is available. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
added
enhancement
|
Here's some pretty broad CI jobs to check for regressions, but it should be noted that the crux of the problem that this change addresses can't be tested on ci.ros2.org because of the way the jobs are structured.
|
|
The idea here looks good to me, and solved the problem in my local testing. So I'm somewhat confident it will fix the underlying problem. It looks like the |
I just suck at package selection arguments. Trying again:
|
clalancette
approved these changes
Jan 29, 2021
|
@cottsay Once you merge this, can you please do a new release of rmw_implementation into Rolling? That should unblock the build of demo_nodes_cpp_native. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_default_rmw_implementationmacro contains the same functionality as is removed by this change, but it contains logic to fall back to any available RMW implementation if neitherRMW_IMPLEMENTATIONis specified nor the default is available.