This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
Include node namespaces in get_node_names #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
reviewed
Aug 29, 2018
rmw_opensplice_cpp/src/rmw_node.cpp
Outdated
| dp_factory->get_default_participant_qos(dpqos); | ||
| dpqos.user_data.value.length(static_cast<DDS::ULong>(length)); | ||
| snprintf(reinterpret_cast<char *>(dpqos.user_data.value.get_buffer(false)), length, "name=%s;", | ||
| name); | ||
| snprintf(reinterpret_cast<char *>(dpqos.user_data.value.get_buffer(false)), |
| rcutils_ret = rcutils_string_array_init(&ns_list, length, &allocator); | ||
| if (rcutils_ret != RCUTILS_RET_OK) { | ||
| RMW_SET_ERROR_MSG(rcutils_get_error_string_safe()) | ||
| return rmw_convert_rcutils_ret_to_rmw_ret(rcutils_ret); |
There was a problem hiding this comment.
I think node_list needs to be cleaned up here.
| if (rcutils_ret != RCUTILS_RET_OK) { | ||
| RCUTILS_LOG_ERROR_NAMED( | ||
| "rmw_opensplice_cpp", | ||
| "failed to cleanup during error handling: %s", rcutils_get_error_string_safe()) |
There was a problem hiding this comment.
Should the return code not change here if the clean up failed?
wjwwood
approved these changes
Sep 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#142