This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
Implement QoS: liveliness, deadline, lifespan #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** * Add rmw qos interfaces * Implement rmw_wait * Implement rmw_take_event * Reformat comments from pr * Add error checking in rmw_wait and rmw_event Signed-off-by: Ross Desmond <44277324+ross-desmond@users.noreply.github.com>
Signed-off-by: Ross Desmond <44277324+ross-desmond@users.noreply.github.com>
29 tasks
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
|
I'm going to hold off reviewing this one until some of the common nitpick's I pointed out in ros2/rmw_connext#352 (review) can be checked for here too. |
|
It doesn't look like any commits have been pushed here since my last comment. I think most of the things I mentioned on the
Maybe you guys could take a pass over this before I do a full review? |
Signed-off-by: Miaofei <miaofei@amazon.com>
|
Hi @wjwwood, the common nitpicks should be corrected now. Thanks! |
wjwwood
suggested changes
Apr 30, 2019
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
wjwwood
approved these changes
May 3, 2019
|
This PR introduces a few compiler warnings, see https://ci.ros2.org/job/ci_packaging_windows/105/warnings43Result/ Please address them in another PR rather sooner than later. |
|
Opened another PR for addressing the new compiler warnings at #269. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide implementation of QoS changes for rmw events. If applied this PR will
Connects to ros2/rmw#171