fix windows build warnings #269

mm318 · 2019-05-07T20:15:08Z

This PR fixes the compiler warnings that showed up on the Windows build (issue brought up at #266 (comment)).

Signed-off-by: Miaofei <miaofei@amazon.com>

mm318 · 2019-05-07T20:42:02Z

@thomas-moulard - please run the following CI job:

Gist file: https://gist.githubusercontent.com/mm318/6c874f81b907d34ad4f0a10f41bf1982/raw/c60e20dee62883f10c81b0e99630a5d774a076e2/ros2.repos
Additional BUILD flags: --packages-up-to rmw_opensplice
Additional TEST flags: --packages-select rmw_opensplice
CI Job: ci_launcher

Please also enable CI_USE_OPENSPLICE.

thomas-moulard · 2019-05-07T23:56:22Z

dirk-thomas

LGTM with passing CI

mm318 · 2019-05-08T00:17:58Z

Sorry @thomas-moulard! It needed to be --packages-up-to rmw_opensplice_cpp/--packages-select rmw_opensplice_cpp, instead of rmw_opensplice.

thomas-moulard · 2019-05-08T01:03:06Z

fix windows build warnings

daa920f

Signed-off-by: Miaofei <miaofei@amazon.com>

tfoote added the in progress Actively being worked on (Kanban column) label May 7, 2019

mm318 mentioned this pull request May 7, 2019

Implement QoS: liveliness, deadline, lifespan #266

Merged

dirk-thomas approved these changes May 8, 2019

View reviewed changes

dirk-thomas merged commit 81e90b8 into ros2:master May 8, 2019

dirk-thomas removed the in progress Actively being worked on (Kanban column) label May 8, 2019

Provide feedback