This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
Enable service typesupport for C #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquelinekay
force-pushed
the
c_services
branch
4 times, most recently
from
65f8fbb
to
f645b49
Compare
|
OSX seems to have problems with the generated C code included the C++ code. Looking into it. |
jacquelinekay
force-pushed
the
c_services
branch
from
9903213
to
3edce3e
Compare
| @@ -267,6 +269,7 @@ ament_target_dependencies( | |||
| ${rosidl_generate_interfaces_TARGET}${_target_suffix} | |||
| "OpenSplice" | |||
| "rosidl_typesupport_opensplice_c") | |||
| #"${PROJECT_NAME}__rosidl_generator_c") | |||
|
Other than the comments it lgtm. Please remember to quash though (lots of small commits here). |
jacquelinekay
force-pushed
the
c_services
branch
from
1bb91de
to
a50b0ec
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rcl#27
depends on #120