Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach sequence number and publisher GID to serialized messages #131

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

AlexDayCRL
Copy link
Contributor

Fixes #130 by attaching the GID and sequence number to the message in rmw_publish_serialized_message mirroring rmw_publish. Tested by building locally and publishing messages from SQLite3 bag and subscribing with ros2 topic hz

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I pushed a small change to fix trailing whitespace. Once CI finishes I'll merge it in.

@clalancette clalancette merged commit 740bfa9 into ros2:rolling Mar 20, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to obtain publisher GID and sequence number errors
2 participants