Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync past tokio bump and drop thread restriction #134

Merged
merged 8 commits into from May 8, 2024

Conversation

Yadunund
Copy link
Member

Undo thread limits imposed by #95 by syncing to zenoh version with tokio async runtime.

To be tested.

Signed-off-by: Yadunund <yadunund@openrobotics.org>
@JEnoch
Copy link
Contributor

JEnoch commented Mar 28, 2024

In my tests with Iron + rmw_zenoh_cpp the Navigation + Turtlebot3 example was failing (RViz not displaying the map).
However after bumping zenoh-c to commit 5b472166fe01d358431b25608aa50db6bb23a5e1 it was successful.

I think the Zenoh fixes eclipse-zenoh/zenoh#853 and eclipse-zenoh/zenoh#861 played a role in this.

However, I still get failures with the Open-RMF Office World, with those repetitive logs:

[gzserver-17] [ERROR] [1711624918.958884561] [slotcar_OpenRobotics/MiR100]: Unable to determine the current level_name for robot [OpenRobotics/MiR100]. Kindly ensure the building_map_server is running. The RobotState message forthis robot will not be published.
[gzserver-17] [ERROR] [1711624918.958973071] [slotcar_tinyRobot1]: Unable to determine the current level_name for robot [tinyRobot1]. Kindly ensure the building_map_server is running. The RobotState message forthis robot will not be published.
[gzserver-17] [ERROR] [1711624918.959000831] [slotcar_tinyRobot2]: Unable to determine the current level_name for robot [tinyRobot2]. Kindly ensure the building_map_server is running. The RobotState message forthis robot will not be published.

I'm investigating...

@Yadunund
Copy link
Member Author

I can also reproduce the same results as you @JEnoch...

@Yadunund Yadunund marked this pull request as ready for review April 4, 2024 14:29
@Yadunund
Copy link
Member Author

Yadunund commented Apr 5, 2024

@JEnoch i'm still unable to repeatably launch the hotel world from rmf_demos. In the screenshot below, RViz does not receive the BuildingMap message form the building_map_server. The fleet_adapter nodes also do not receive any RobotState message over /robot_state and hence do not initialize. This was tested within a clean worksapce with Iron binaries of ROS 2 and Open-RMF.
I do see better results when I re-introduce the thread restriction to 1 but also not consistent.

ros2 launch rmf_demos_gz hotel.launch.xml

image

Will continue testing...

Yadunund and others added 2 commits April 18, 2024 23:41
* updated zenoh-c to latest commit

* updated zenoh-c commit comment

* Updated comment in cmake
@Yadunund
Copy link
Member Author

Yadunund commented May 7, 2024

The issues have been resolved by #164. Going ahead and merging this PR.

@Yadunund Yadunund merged commit 868b64e into rolling May 8, 2024
6 checks passed
@Yadunund Yadunund deleted the yadu/bump_zenoh_with_tokio branch May 8, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants