Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix service with custom mapped message field #234

Merged

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Jan 10, 2020

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added the bug Something isn't working label Jan 10, 2020
@dirk-thomas dirk-thomas self-assigned this Jan 10, 2020
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@dirk-thomas dirk-thomas merged commit f471464 into master Jan 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-service-with-custom-mapped-msg-field branch January 12, 2020 17:58
@dirk-thomas
Copy link
Member Author

Synced change to eloquent branch.

dirk-thomas added a commit that referenced this pull request Jan 15, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas added a commit that referenced this pull request Jan 15, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
athackst pushed a commit to athackst/ros1_bridge that referenced this pull request Feb 14, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Allison Thackston <allison@lyonthackston.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants