Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to correct Examples 4 #357

Merged
merged 1 commit into from
May 19, 2022
Merged

to correct Examples 4 #357

merged 1 commit into from
May 19, 2022

Conversation

xlla
Copy link
Contributor

@xlla xlla commented May 2, 2022

I have tested it.

terminal 1

ros2 run ros1_bridge parameter_bridge
Trying to create bidirectional bridge for topic '/chatter' with ROS 2 type 'std_msgs/msg/String'
[INFO] [1651472131.323351466] [ros_bridge]: create bidirectional bridge for topic /chatter
The parameter 'services_1_to_2' either doesn't exist or isn't an array
Trying to create bridge for ROS 1 service '/add_two_ints' with type 'roscpp_tutorials/TwoInts'
Created 2 to 1 bridge for service /add_two_ints
[INFO] [1651472131.772500582] [ros_bridge]: Passing message from ROS 1 std_msgs/String to ROS 2 std_msgs/msg/String (showing msg only once per type)

terminal 2

$ rosrun roscpp_tutorials add_two_ints_server
[ INFO] [1651472257.007540349]: request: x=1, y=2
[ INFO] [1651472257.010445376]:   sending back response: [3]

terminal 3

$ ros2 service call /add_two_ints example_interfaces/srv/AddTwoInts "{a: 1, b: 2}"
requester: making request: example_interfaces.srv.AddTwoInts_Request(a=1, b=2)

response:
example_interfaces.srv.AddTwoInts_Response(sum=3)


Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the change! It's a bit confusing that the topic bridge is bidirectional whereas the service bridge isn't, I'll raise a separate PR to clarify the wording (:

@methylDragon methylDragon merged commit 54eb133 into ros2:master May 19, 2022
hsd-dev pushed a commit to hsd-dev/ros1_bridge that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants