-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Humble] Backport CycloneDDS 0.10.x release. #1404
Conversation
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Regardless of the outcome, I feel like we should hold off on backporting this to a stable distro for a while. After all, we only updated Rolling this morning. |
That seems like a good idea to me 👍 |
I think that's reasonable. |
Yay!!! It passed! |
Since it's been two weeks and it passed all the tests, could we consider merging so it can get into ros2-testing? I think 0.10 provides not only significant improvement but the features that are missing for using it in multiple configured dynamic networks (which seems to be a recurring issue for people). I view this as being a critical upgrade for use in humble, it would be rather unfortunate to have to jump to Iron or wait for J-Turtle. |
Sorry, I don't think this isn't nearly long enough. Rolling doesn't have a huge amount of users, so just having it in there for a couple of weeks doesn't give us much testing. I think we should wait until Iron has been released (May 23rd) before we consider a backport to Humble. We'll do a lot more testing in the next 4 weeks, so that should give us more confidence in the change. |
@clalancette @audrow @nuclearsandwich you guys think it's use on Iron has proven "stable enough" now for us to merge? |
Yeah, I think this is probably OK now. It's been out in Rolling and Iron for a while and we haven't heard complaints. @audrow what I think we should do here is to merge this in, and then immediately do a new release of cyclonedds into Humble from the 0.10.x branch. Then we can let that sit in testing for a few weeks before doing a patch release. Does that make sense? Can you take care of that? |
@clalancette, I can do that. I've been sick this week. I'll probably get to it early next week. |
Release PR opened: ros/rosdistro#38309 |
Update CycloneDDS to 0.10.x release.
This allows for use of
presence_required
for transient configured networks.