Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Humble] Backport CycloneDDS 0.10.x release. #1404

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

bperseghetti
Copy link

Update CycloneDDS to 0.10.x release.

This allows for use of presence_required for transient configured networks.

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
@nuclearsandwich
Copy link
Member

Here's an initial run of comprehensive CI, I did not disable linter tests, which I used to do when testing stable distros due to linter drift but I think that we've mostly moved to using Ubuntu-distributed linters so that may be less of an issue now. We'll find out.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@nuclearsandwich nuclearsandwich changed the title Move CycloneDDS to 0.10.x release. [Humble] Backport CycloneDDS 0.10.x release. Apr 6, 2023
@clalancette
Copy link
Contributor

Regardless of the outcome, I feel like we should hold off on backporting this to a stable distro for a while. After all, we only updated Rolling this morning.

@audrow
Copy link
Member

audrow commented Apr 6, 2023

Regardless of the outcome, I feel like we should hold off on backporting this to a stable distro for a while. After all, we only updated Rolling this morning.

That seems like a good idea to me 👍

@bperseghetti
Copy link
Author

Regardless of the outcome, I feel like we should hold off on backporting this to a stable distro for a while. After all, we only updated Rolling this morning.

I think that's reasonable.

@bperseghetti
Copy link
Author

Here's an initial run of comprehensive CI, I did not disable linter tests, which I used to do when testing stable distros due to linter drift but I think that we've mostly moved to using Ubuntu-distributed linters so that may be less of an issue now. We'll find out.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Yay!!! It passed!

@bperseghetti
Copy link
Author

bperseghetti commented Apr 17, 2023

Since it's been two weeks and it passed all the tests, could we consider merging so it can get into ros2-testing? I think 0.10 provides not only significant improvement but the features that are missing for using it in multiple configured dynamic networks (which seems to be a recurring issue for people).

I view this as being a critical upgrade for use in humble, it would be rather unfortunate to have to jump to Iron or wait for J-Turtle.

@clalancette
Copy link
Contributor

Since it's been two weeks and it passed all the tests, could we consider merging so it can get into ros2-testing?

Sorry, I don't think this isn't nearly long enough. Rolling doesn't have a huge amount of users, so just having it in there for a couple of weeks doesn't give us much testing. I think we should wait until Iron has been released (May 23rd) before we consider a backport to Humble. We'll do a lot more testing in the next 4 weeks, so that should give us more confidence in the change.

@bperseghetti
Copy link
Author

@clalancette @audrow @nuclearsandwich you guys think it's use on Iron has proven "stable enough" now for us to merge?

@clalancette
Copy link
Contributor

@clalancette @audrow @nuclearsandwich you guys think it's use on Iron has proven "stable enough" now for us to merge?

Yeah, I think this is probably OK now. It's been out in Rolling and Iron for a while and we haven't heard complaints.

@audrow what I think we should do here is to merge this in, and then immediately do a new release of cyclonedds into Humble from the 0.10.x branch. Then we can let that sit in testing for a few weeks before doing a patch release. Does that make sense? Can you take care of that?

@audrow
Copy link
Member

audrow commented Aug 11, 2023

@audrow what I think we should do here is to merge this in, and then immediately do a new release of cyclonedds into Humble from the 0.10.x branch. Then we can let that sit in testing for a few weeks before doing a patch release. Does that make sense? Can you take care of that?

@clalancette, I can do that. I've been sick this week. I'll probably get to it early next week.

@audrow audrow merged commit 74aa201 into ros2:humble Aug 14, 2023
@audrow
Copy link
Member

audrow commented Aug 22, 2023

Release PR opened: ros/rosdistro#38309

@bperseghetti bperseghetti deleted the humble-cyclonedds-0.10.x branch August 22, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants