-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding geometry_experimental #160
Conversation
+1 |
Is |
Well, we have to figure something out so that we can get tf into ROS 2 for the upcoming alpha 3. I guess you should start by considering how to remove or replace |
My opinion is that we should take |
The only remaining issue with #133 is that it introduces warnings on Windows: #134 (comment) Those should be easy to fix, especially if you limit them to just |
This needs ros2/rclcpp#172 to continue. I'll test that shortly. |
Linux CI passing: http://ci.ros2.org/job/ci_linux/721/ |
Please review the pull request with the changes here: ros/geometry2#135 |
@@ -106,7 +110,7 @@ repositories: | |||
ros2/rosidl: | |||
type: git | |||
url: https://github.com/ros2/rosidl.git | |||
version: master | |||
version: inject_rmw_dependenc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final run of osx passed with only unrelated failures: http://ci.ros2.org/job/ci_osx/684/ |
Those last couple of test failures should be addressed by ros2/system_tests#98. |
Squashed commit, upstream merged. Merging this. |
Connects to #153
Requires #159
Linux CI job passing: http://ci.ros2.org/job/ci_linux/677/#showFailuresLink