Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding geometry_experimental #160

Merged
merged 1 commit into from
Dec 18, 2015
Merged

adding geometry_experimental #160

merged 1 commit into from
Dec 18, 2015

Conversation

tfoote
Copy link
Contributor

@tfoote tfoote commented Dec 6, 2015

Connects to #153

Requires #159

Linux CI job passing: http://ci.ros2.org/job/ci_linux/677/#showFailuresLink

@tfoote tfoote self-assigned this Dec 6, 2015
@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Dec 6, 2015
@esteve
Copy link
Member

esteve commented Dec 7, 2015

+1

@gerkey
Copy link
Member

gerkey commented Dec 7, 2015

Is geometry_experimental also building successfully on Windows and OSX?

@tfoote
Copy link
Contributor Author

tfoote commented Dec 7, 2015

@gerkey It's not tested on OSX or Windows. There's missing dependencies with console_bridge see #159 I don't know how we should proceed with console_bridge.

@gerkey
Copy link
Member

gerkey commented Dec 7, 2015

Well, we have to figure something out so that we can get tf into ROS 2 for the upcoming alpha 3. I guess you should start by considering how to remove or replace console_bridge (maybe an alternative cross-platform implementation that just calls printf()/cout()?).

@wjwwood
Copy link
Member

wjwwood commented Dec 8, 2015

My opinion is that we should take console_bridge as it is in #133 and go with that rather than replacing it. I tested console_bridge and class_loader on all the platforms in my branch #133. The only outstanding thing to do (which could be delayed) is resolving the issue @dirk-thomas pointed out: #159 (comment)

@wjwwood
Copy link
Member

wjwwood commented Dec 8, 2015

The only remaining issue with #133 is that it introduces warnings on Windows: #134 (comment)

Those should be easy to fix, especially if you limit them to just console_bridge and don't take class_loader for now.

@tfoote
Copy link
Contributor Author

tfoote commented Dec 11, 2015

This needs ros2/rclcpp#172 to continue. I'll test that shortly.

@tfoote
Copy link
Contributor Author

tfoote commented Dec 14, 2015

Linux CI passing: http://ci.ros2.org/job/ci_linux/721/
Clang is more strict on some datatype conversions inside sleep in rate.hpp, that need to be worked out: http://ci.ros2.org/job/ci_osx/599/console
And Windows there are some issues with implicit datatype conversions: http://ci.ros2.org/job/ci_windows_opensplice/785/console

@gerkey
Copy link
Member

gerkey commented Dec 15, 2015

@wjwwood Please make a PR to allow review of the ros2 branch of console_bridge.

@tfoote Same for tf2_ament branch of geometry_experimental.

@tfoote
Copy link
Contributor Author

tfoote commented Dec 16, 2015

Please review the pull request with the changes here: ros/geometry2#135

@@ -106,7 +110,7 @@ repositories:
ros2/rosidl:
type: git
url: https://github.com/ros2/rosidl.git
version: master
version: inject_rmw_dependenc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjwwood We added this here as a workaround to #174

@tfoote
Copy link
Contributor Author

tfoote commented Dec 18, 2015

@tfoote
Copy link
Contributor Author

tfoote commented Dec 18, 2015

Final run of osx passed with only unrelated failures: http://ci.ros2.org/job/ci_osx/684/

@gerkey
Copy link
Member

gerkey commented Dec 18, 2015

Those last couple of test failures should be addressed by ros2/system_tests#98.

@tfoote
Copy link
Contributor Author

tfoote commented Dec 18, 2015

Squashed commit, upstream merged. Merging this.

tfoote added a commit that referenced this pull request Dec 18, 2015
adding geometry_experimental
@tfoote tfoote merged commit 2c78c4d into master Dec 18, 2015
@tfoote tfoote removed the in progress Actively being worked on (Kanban column) label Dec 18, 2015
@tfoote tfoote deleted the add_tf branch December 18, 2015 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants